-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test runner): Support for disable bail #3074
Conversation
This enables tracking all tests that killed a mutant instead of just the first
Ok. So I progressed a little:
|
I've been trying to make jest bail in the integration tests based on config but I haven't succeeded. Calling jest's I added a test that should pass if jest bailed on the first fail. It's skipped for now because jest does not bail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your continued work on this. I've started implementing the e2e tests for jest (and prepared it for adding mocha, jasmine, karma and cucumber as well).
Please take a look at my remarks with regards to jest.
Co-authored-by: Nico Jansen <jansennico@gmail.com>
I've opened an issue in jest: jestjs/jest#11766. I'll try to implement programmatical We've discussed this in the community meetup and decided to investigate in which version of jest the 'monkey patch' was working. If we can't find a version of jest in which it worked, we'll just remove the feature entirely. We can mimic the behavior of bail by simply only reporting on the first failing test when bail is enabled. |
As discussed in #2996 and #3012 this PR enables the user to set a
disableBail
option to collect all tests killing a mutant. Continuation of #3061Notes on the implementation:
To be done:
bail = true
. I am not sure what to do about this or if this is a problem with my implementation.[@nicojs]: This is a problem of our jest-runner implementation. Running with
bail
apparently never worked 🤷♀️. I've removed the implementation and mimicked the behavior of reporting the first failing test when bail is enabled.disableBail
in the cucumber runnerdisableBail
in the jasmine runnerdisableBail
in the karma runnerdisableBail
in the mocha runner