Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the mingwX64 platform #276

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add support for the mingwX64 platform #276

merged 1 commit into from
Aug 29, 2024

Conversation

garyp
Copy link
Collaborator

@garyp garyp commented Aug 25, 2024

I tried adding mingwX64 to the conformance tests too, but it turns out that the conformance test runner is not supported under Windows by the upstream protobuf project. So this PR only includes runtime support for mingwX64. I'll push the conformance test mingwX64 support to a branch, but it doesn't make sense to merge it until the protobuf project actually supports running conformance tests on Windows.

Fixes #233

@garyp garyp force-pushed the garyp/mingw branch 11 times, most recently from 1fa34b0 to 383ac56 Compare August 29, 2024 01:49
@garyp garyp changed the title WIP: mingwX64 support Add support for the mingwX64 platform Aug 29, 2024
@garyp garyp added this to the 0.16.0 milestone Aug 29, 2024
@garyp garyp marked this pull request as ready for review August 29, 2024 10:28
@garyp garyp requested a review from kjanderson2 August 29, 2024 10:29
@garyp garyp merged commit d9b3aa6 into master Aug 29, 2024
4 checks passed
@garyp garyp deleted the garyp/mingw branch August 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mingwX64 native support
1 participant