Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clear() to useSet #2535

Merged
merged 3 commits into from
Jan 15, 2024
Merged

feat: Add clear() to useSet #2535

merged 3 commits into from
Jan 15, 2024

Conversation

suisous
Copy link
Contributor

@suisous suisous commented Jan 5, 2024

Description

In using useSet, we decided that we needed a method that could erase all values.
We have also added text to the documentation regarding the behavior of the reset method.
(using translation)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

馃帀 This is my first pull request!

Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@streamich streamich merged commit 06afdf7 into streamich:master Jan 15, 2024
8 checks passed
@suisous
Copy link
Contributor Author

suisous commented Jan 16, 2024

馃槂 Thank you for accepting the changes!
Can't wait for this to be released!

@streamich
Copy link
Owner

馃帀 This PR is included in version 17.4.4 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants