Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump fs-monkey minimum version for rm support #909

Merged
merged 1 commit into from Jun 7, 2023

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Jun 6, 2023

Version 1.0.4 supports .rm and .rmSync: https://github.com/streamich/fs-monkey/releases/tag/v1.0.4

Technically, the existing version specification allows this drift:

memfs/package.json

Lines 78 to 80 in 09eab27

"dependencies": {
"fs-monkey": "^1.0.3"
},

However, for completeness, we should use ^1.0.4 so rm* "just works".

Closes #884

@blimmer
Copy link
Contributor Author

blimmer commented Jun 7, 2023

Oh, whoops, I see the issue with the lockfile. Fixing!

@blimmer
Copy link
Contributor Author

blimmer commented Jun 7, 2023

Should be fixed now @G-Rath - thanks!

@G-Rath G-Rath merged commit 595a473 into streamich:master Jun 7, 2023
13 checks passed
streamich pushed a commit that referenced this pull request Jun 7, 2023
## [3.5.3](v3.5.2...v3.5.3) (2023-06-07)

### Bug Fixes

* bump fs-monkey minimum version for rm support ([#909](#909)) ([595a473](595a473))
@streamich
Copy link
Owner

🎉 This PR is included in version 3.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.rm/.rmSync are not available
3 participants