fix: ensure metadata is updated correctly so that watchFile is correctly triggered
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
requested changes
Feb 10, 2023
|
@vangie would you mind applying prettier, then I think we can land this |
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
0762647
to
edb06aa
Compare
G-Rath
approved these changes
Apr 11, 2023
G-Rath
changed the title
watchFile is correctly triggered
|
@vangie looks like it's still not happy, and the tests are all failing |
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
edb06aa
to
85a0f5a
Compare
G-Rath
reviewed
Apr 11, 2023
|
It's a security thing - you should be able to run the tests locally though to ensure they work. It looks like this is not compatible with #902 - @alienzhou might be able to help out here |
…node.watchFile not trigger 1. nlink default value is 2 2. add subfolder nlink++ 3. atime updated 4. ctime updated after uid/gid/atime/mtime/perm/nlink updated streamich#889
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
85a0f5a
to
a5c99bd
Compare
@G-Rath I've rebased the latest master, and fixed the tests. |
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
a5c99bd
to
78ccec9
Compare
G-Rath
requested changes
Apr 15, 2023
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
af531b2
to
48a6cad
Compare
G-Rath
requested changes
Apr 17, 2023
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
48a6cad
to
e339817
Compare
G-Rath
reviewed
Apr 18, 2023
refactor: add the appropriate modifiers to properties & getters & setters. Co-authored-by: Gareth Jones <Jones258@Gmail.com>
vangie
force-pushed
the
vangie/metadata-changes-follow-common-unix-filesystem
branch
from
e339817
to
1a1b186
Compare
G-Rath
approved these changes
Apr 20, 2023
streamich
pushed a commit
that referenced
this pull request
Apr 20, 2023
## [3.5.1](v3.5.0...v3.5.1) (2023-04-20) ### Bug Fixes * ensure metadata is updated correctly so that `watchFile` is correctly triggered ([#891](#891)) ([8af880e](8af880e))
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #889
Resolves #901