-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust to deprecations for graphql_core v.3.2 #2894
Adjust to deprecations for graphql_core v.3.2 #2894
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
- Coverage 96.37% 96.37% -0.01%
==========================================
Files 207 207
Lines 8969 8966 -3
Branches 1648 1649 +1
==========================================
- Hits 8644 8641 -3
Misses 206 206
Partials 119 119 |
af1a88e
to
2b9919e
Compare
…oved to graphql.execution
Thanks for adding the Here's a preview of the changelog: This release removes some usage of deprecated functions from GraphQL-core. Here's the preview release card for twitter: Here's the tweet text:
|
171d291
to
8b8b197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting Strawberry ready for graphql-core 3.3 @kristjanvalur. Straightforward yet super welcome changes!
@@ -250,7 +249,7 @@ async def get_result_source(): | |||
# Handle initial validation errors | |||
if isinstance(result_source, GraphQLExecutionResult): | |||
assert result_source.errors | |||
payload = [format_graphql_error(result_source.errors[0])] | |||
payload = [err.formatted for err in result_source.errors] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
Co-authored-by: Patrick Arminio <patrick.arminio@gmail.com>
the
format_error()
function to turnGraphQLError
intoGraphQLFormattedError
is deprecatedfor
graphql-core
3.2 and will be removed for version 3.3.graphql.subscription
module is deprecated, its contents moved tographql.execution
No other deprecated features seem to be in use in strawberry.
Current version in strawberry is "~3.2.0"
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist