Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Pass all arguments to configure through in svelte to fix StoryStoreV6 #21491

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 8, 2023

Closes storybookjs/addon-svelte-csf#79

What I did

Make sure Svelte (and Ember) renderers pass all arguments to configure through, including the vital last argument :)

How to test

  1. Run svelte sandbox: yarn start --template svelte-vite/default-ts
  2. Disable SSv7
  3. Ensure it works.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Sorry, something went wrong.

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JReinhold JReinhold merged commit d215086 into next Mar 9, 2023
@JReinhold JReinhold deleted the tom/svelte-79-fix-svelte-configure branch March 9, 2023 14:51
@IanVS
Copy link
Member

IanVS commented Mar 9, 2023

It would be awesome if this were documented somewhere so others creating renderers would know. CC @jonniebigodes.

@shilman shilman mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Does not work with Storybook 7.0.0-alpha.52 and storyStoreV6
3 participants