-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Test: Support Vitest 3 browser.test.instances field #30309
Addon Test: Support Vitest 3 browser.test.instances field #30309
Conversation
This reverts commit e90d717.
View your CI Pipeline Execution ↗ for commit 2bf54fb.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
d208cfb
to
678fb8f
Compare
Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/12909400525 |
browser.test.instances
instead of browser.test.name
…es-vitest-3 Addon Test: Support Vitest 3 browser.test.instances field (cherry picked from commit 4d2989d)
…es-vitest-3 Addon Test: Support Vitest 3 browser.test.instances field (cherry picked from commit 4d2989d)
Closes #30299
Closes #30308
Closes #30363
What I did
When creating a
vitest.workspace
orvitest.config
file for the user upon@storybook/experimental-addon-test
initialization, we will correctly set a Vitest 3 compatible configuration if we detect that the user is using Vitest 3.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30309-sha-d2c3d566
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30309-sha-d2c3d566 sandbox
or in an existing project withnpx storybook@0.0.0-pr-30309-sha-d2c3d566 upgrade
.More information
0.0.0-pr-30309-sha-d2c3d566
valentin/introduce-instances-vitest-3
d2c3d566
1737553195
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30309
Greptile Summary
Based on the provided information, I'll create a concise summary of the changes in this PR:
Updates Storybook's test addon to support Vitest 3's new browser configuration format, replacing the deprecated
browser.name
withbrowser.instances
array.code/addons/test/src/postinstall.ts
to detect Vitest version and generate appropriate browser configurationcode/.storybook/vitest.config.ts
to usebrowser.instances
array for Vitest 3 compatibilitytest-storybooks/portable-stories-kitchen-sink/react/vitest.workspace.ts
to align with new Vitest 3 browser configuration format