using ai-codewise int for dogfooding #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Please find StepSecurity AI-CodeWise code comments inline.
Feedback
We appreciate your feedback in helping us improve the service! To provide feedback, please use emojis on this comment. If you find a comment helpful, give it a 👍. If they aren't useful, kindly express that with a 👎. If you have questions or detailed feedback, please create n GitHub issue in StepSecurity/AI-CodeWise.
| @@ -1,27 +1,23 @@ | |||
| name: Code Review | |||
| on: | |||
| pull_request: | |||
| branches: | |||
There was a problem hiding this comment.
- [Low]Use specific branches instead of all branches
The workflow will trigger for all branches. Use a specific branch to trigger the workflow
| @@ -1,27 +1,23 @@ | |||
| name: Code Review | |||
| on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| - int | |||
| permissions: | |||
| contents: read | |||
There was a problem hiding this comment.
- [Low]Remove unnecessary permission
Contents read permission is not needed since pull-requests: read already includes it. Remove contents: read permission
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@128a63446a954579617e875aaab7d2978154e969 # v2.4.0 | ||
| with: | ||
| egress-policy: audit |
There was a problem hiding this comment.
- [Medium]Limit egress traffic
The workflow runner allows all outgoing traffic by default. Set the egress-policy to either 'block-all' or 'audit' (requires permission write), or list specific allowed endpoints with allowed-endpoints key
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@128a63446a954579617e875aaab7d2978154e969 # v2.4.0 | ||
| with: | ||
| egress-policy: audit | ||
| disable-sudo: true |
There was a problem hiding this comment.
- [High]Do not disable sudo without proper justification
Disabling sudo may cause the runner to fail executing some steps. If there is no proper justification for disabling sudo, remove it
|
|
||
| - name: Code Review | ||
| uses: docker://ghcr.io/step-security/code-reviewer/int:latest |
There was a problem hiding this comment.
- [Informational]Update the Docker image to the latest stable release
The image used for the Code Review step does not use the latest stable release. Update the Docker image to the latest stable release
varunsh-coder
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.