build: improve nodeResolve config
#6203
Merged
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Stencil's default
nodeResolveconfig doesn't pay attention to theexports>requirefield (which is present in the axios lib - axios/axios#5888)GitHub Issue Number: #6202
What is the new behavior?
Closes #6202
requirein nodeResolveexportConditions(Note - I'm not 100% sure if we should as I think axios is in the wrong here - Missing constant in axios/lib/adapters/http.js zlibOptions axios/axios#5888 (comment))nodeResolvetypes to match the pluginnodeResolveconfig to take precedence over default - giving users more controlDocumentation
Does this introduce a breaking change?
Testing
Other information