Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve nodeResolve config #6203

Conversation

johnjenkins
Copy link
Contributor

@johnjenkins johnjenkins commented Mar 13, 2025

What is the current behavior?

Stencil's default nodeResolve config doesn't pay attention to the exports > require field (which is present in the axios lib - axios/axios#5888)

GitHub Issue Number: #6202

What is the new behavior?

Closes #6202

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

Sorry, something went wrong.

@johnjenkins johnjenkins requested a review from a team as a code owner March 13, 2025 13:20
John Jenkins added 2 commits March 13, 2025 13:24
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@christian-bromann christian-bromann merged commit 34d2284 into stenciljs:main Mar 13, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: axios with stencil throws Cannot read properties of undefined (reading 'Z_SYNC_FLUSH')
2 participants