Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic when the WebSocket endpoint is under load #364

Merged
merged 1 commit into from
May 23, 2024

Conversation

rodrigorfk
Copy link
Contributor

Only closes the communication channel once the send host timer routine has finished and therefore avoid getting it writing to the channel which was already closed.

Fixes #363 .

Verified

This commit was signed with the committer’s verified signature.
bjoerge Bjørge Næss
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @rodrigorfk 🥇

@stefanprodan stefanprodan merged commit 220d4e9 into stefanprodan:master May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podinfo crashes with panic when the WebSocket endpoint is under load
2 participants