Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue 2 recipe #4009

Merged
merged 4 commits into from
May 23, 2023
Merged

Update Vue 2 recipe #4009

merged 4 commits into from
May 23, 2023

Conversation

amypellegrini
Copy link
Contributor

@amypellegrini amypellegrini commented May 11, 2023

Added context on XState usage depending on the version of Vue.

Added context on Xstate usage depending on the version of Vue.
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

⚠️ No Changeset found

Latest commit: af0b837

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af0b837:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented May 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

docs/recipes/vue.md Outdated Show resolved Hide resolved
docs/recipes/vue.md Outdated Show resolved Hide resolved
docs/recipes/vue.md Outdated Show resolved Hide resolved
@Andarist
Copy link
Member

I've noticed that it's still in the draft. Is there any other information that you plan to add to this PR?

@amypellegrini
Copy link
Contributor Author

Hi @Andarist yes, I intend to work on the whole page so I think it makes sense to wait until the whole editing is done before merging, instead of having multiple PR's. Unless you think it's better otherwise, just let me know.

docs/recipes/vue.md Outdated Show resolved Hide resolved
@amypellegrini
Copy link
Contributor Author

I made the distinction between using the external plugin or using interpret more explicit. I'm not sure if it is possible to make use of the setup feature from Vue for the interpret example:

https://vuejs.org/api/sfc-script-setup.html

@amypellegrini amypellegrini marked this pull request as ready for review May 16, 2023 06:40
@amypellegrini
Copy link
Contributor Author

I'm not sure if I should add a change set for this, but my best guess is that docs are not versioned since they are not inside the packages folder. Please let me know if I should add a change set, I try to learn more about how the docs are built so I can make PR's easier to merge.

@davidkpiano davidkpiano merged commit 675caff into statelyai:main May 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants