Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Prevent error when writing to Comb index file #10712

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue caused by #10695 where an error would be thrown when attempting to write the index's JSON file if the storage/statamic/search directory doesn't exist.

This was happening under the hood when we were using the Flysystem stuff.

Verified

This commit was signed with the committer’s verified signature.
duncanmcclean Duncan McClean
@duncanmcclean duncanmcclean changed the title [5.x] Ensure directory exists before attempting to write to search index [5.x] Fix error when writing to Comb index file Aug 27, 2024
@duncanmcclean duncanmcclean changed the title [5.x] Fix error when writing to Comb index file [5.x] Prevent error when writing to Comb index file Aug 27, 2024
@jasonvarga jasonvarga merged commit 5db4f65 into 5.x Sep 3, 2024
20 checks passed
@jasonvarga jasonvarga deleted the fix/writing-to-comb-search-index branch September 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants