Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support release branches #231

Closed
1 task
mdesmet opened this issue Feb 17, 2023 · 2 comments
Closed
1 task

Support release branches #231

mdesmet opened this issue Feb 17, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mdesmet
Copy link
Member

mdesmet commented Feb 17, 2023

Describe the feature

  • CREATE BRANCH for each minor release based on the latest patch tag for each minor
  • CREATE CHANGELOG on master branch that refers each minor version latest changeling on the relevant release branch
  • Make every release compatible with version bump (standardised setup.py and version.py)
  • Ensure master + release branches are tested on push
  • Ensure master + release branches are tested on pull request

Describe alternatives you've considered

No response

Who will benefit?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@mdesmet mdesmet added the enhancement New feature or request label Feb 17, 2023
@damian3031
Copy link
Member

Currently dbt trino release workflow uses this github action. Unfortunately, this github action sets every release as latest, so while making backport and releasing 1.0.4, it would be set as latest github release. There is make_latest github API parameter which could be set to false, to avoid setting backported releases as latest ones. Unfortunately, this GH action doesn't support this parameter, and will never do, as this repository is archived.
So, it would require to manually change which version is latest after releasing backported version, or some refactor in a release workflow.

There is another gh action which I used in PyTrino release workflow, which has pending PR for addition of this parameter, maybe it could be used instead after adding this make_latest option there.

@mdesmet
Copy link
Member Author

mdesmet commented Feb 24, 2023

Unfortunately, this GH action doesn't support this parameter, and will never do, as this repository is archived.

So, it would require to manually change which version is latest after releasing backported version, or some refactor in a release workflow.

As discussed offline, let's not worry about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants