Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of arguments in Standard::Base test assertions #584

Merged
merged 1 commit into from Oct 11, 2023

Conversation

jackjennings
Copy link
Contributor

@jackjennings jackjennings commented Oct 9, 2023

This is a minor fix to these tests to make failing test output easier to diagnose. Currently when these tests fail the "actual" and "expected" output are inverted.

I noticed this while working on a lint roller plugin that was a fork of standard-custom (where this issue also exists).

@searls
Copy link
Contributor

searls commented Oct 11, 2023

Right on, thanks

@searls searls merged commit d230e85 into standardrb:main Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants