Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest eslint-plugin-n #271

Merged
merged 1 commit into from May 19, 2023
Merged

Conversation

voxpelli
Copy link
Member

A new major version, 16.x, of eslint-plugin-n was released. This adds support for that one without breaking support with 15.x

@voxpelli voxpelli self-assigned this May 16, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
eslint-plugin-n@16.0.0 filesystem +6 weiran.zsd

voxpelli added a commit to voxpelli/eslint-config that referenced this pull request May 16, 2023
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

@nolddor
Copy link

nolddor commented May 19, 2023

Does it looks OK to you @Flet (?)

@voxpelli voxpelli merged commit 1458f04 into master May 19, 2023
2 checks passed
@theoludwig theoludwig deleted the fix/support-latest-plugin-n branch May 19, 2023 14:56
@UlrichHP
Copy link

Is there a date for when this will be released ?
Are you waiting for something else before creating a new release tag ?
Thanks

@voxpelli
Copy link
Member Author

Released it as 17.1.0

@voxpelli voxpelli mentioned this pull request May 29, 2023
@voxpelli voxpelli removed the request for review from Flet May 29, 2023 18:08
@falsepopsky
Copy link

@voxpelli sorry, does this extra space can lead to future errors for package managers to understand peerDependencies?, i'm using pnpm and for now looks good, but i don't know the other ones.

"eslint-plugin-n": "^15.0.0 || ^16.0.0 ",

for example in eslint-config-standard-with-typescript CI it's being used to compare "Own peerDependencies include those of eslint-config-standard":

   eslint-plugin-n

  Difference (- actual, + expected):

  - '^15.0.0'
  + '^15.0.0 || ^16.0.0 '<anonymous> (src/index.test.ts:338:9)
  › Array.forEach (<anonymous>)
  › <anonymous> (src/index.test.ts:334:6)

https://github.com/standard/eslint-config-standard-with-typescript/actions/runs/5113864674/jobs/9193539738?pr=1147#step:10:45

@voxpelli
Copy link
Member Author

That extra space was unintentional but shouldn't break anything for those who are passing it as proper semantic versioning.

Feel free to open an issue / PR about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants