-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest eslint-plugin-n
#271
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
To avoid rolling back before standard/eslint-config-standard#271 has landed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! 👍
Does it looks OK to you @Flet (?) |
Is there a date for when this will be released ? |
Released it as |
@voxpelli sorry, does this extra space can lead to future errors for package managers to understand peerDependencies?, i'm using pnpm and for now looks good, but i don't know the other ones. eslint-config-standard/package.json Line 54 in da3454f
for example in eslint-plugin-n
Difference (- actual, + expected):
- '^15.0.0'
+ '^15.0.0 || ^16.0.0 '
› <anonymous> (src/index.test.ts:338:9)
› Array.forEach (<anonymous>)
› <anonymous> (src/index.test.ts:334:6)
|
That extra space was unintentional but shouldn't break anything for those who are passing it as proper semantic versioning. Feel free to open an issue / PR about it |
A new major version, 16.x, of
eslint-plugin-n
was released. This adds support for that one without breaking support with 15.x