Skip to content

Commit b28b345

Browse files
author
Bharath Nallapeta
authoredFeb 21, 2024
Merge pull request #612 from fdberlking/issue/587
issue/587 - [BUG] helm labels and annotations are added to k8s manifests built with kustomize
2 parents 3630836 + 0398d54 commit b28b345

File tree

4 files changed

+4
-53
lines changed

4 files changed

+4
-53
lines changed
 

‎deployments/kubernetes/manifests/clusterrole.yaml

+1-10
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,6 @@ apiVersion: rbac.authorization.k8s.io/v1
44

55
kind: ClusterRole
66
metadata:
7-
annotations:
8-
meta.helm.sh/release-namespace: "default"
9-
meta.helm.sh/release-name: "reloader"
10-
labels:
11-
app: reloader-reloader
12-
chart: "reloader-1.0.68"
13-
release: "reloader"
14-
heritage: "Helm"
15-
app.kubernetes.io/managed-by: "Helm"
167
name: reloader-reloader-role
178
rules:
189
- apiGroups:
@@ -64,4 +55,4 @@ rules:
6455
- events
6556
verbs:
6657
- create
67-
- patch
58+
- patch

‎deployments/kubernetes/manifests/clusterrolebinding.yaml

+1-10
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,6 @@ apiVersion: rbac.authorization.k8s.io/v1
44

55
kind: ClusterRoleBinding
66
metadata:
7-
annotations:
8-
meta.helm.sh/release-namespace: "default"
9-
meta.helm.sh/release-name: "reloader"
10-
labels:
11-
app: reloader-reloader
12-
chart: "reloader-1.0.68"
13-
release: "reloader"
14-
heritage: "Helm"
15-
app.kubernetes.io/managed-by: "Helm"
167
name: reloader-reloader-role-binding
178
roleRef:
189
apiGroup: rbac.authorization.k8s.io
@@ -21,4 +12,4 @@ roleRef:
2112
subjects:
2213
- kind: ServiceAccount
2314
name: reloader-reloader
24-
namespace: default
15+
namespace: default

‎deployments/kubernetes/manifests/deployment.yaml

+1-23
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,6 @@
33
apiVersion: apps/v1
44
kind: Deployment
55
metadata:
6-
annotations:
7-
meta.helm.sh/release-namespace: "default"
8-
meta.helm.sh/release-name: "reloader"
9-
labels:
10-
app: reloader-reloader
11-
chart: "reloader-1.0.68"
12-
release: "reloader"
13-
heritage: "Helm"
14-
app.kubernetes.io/managed-by: "Helm"
15-
group: com.stakater.platform
16-
provider: stakater
17-
version: v1.0.68
186
name: reloader-reloader
197
namespace: default
208
spec:
@@ -25,16 +13,6 @@ spec:
2513
app: reloader-reloader
2614
release: "reloader"
2715
template:
28-
metadata:
29-
labels:
30-
app: reloader-reloader
31-
chart: "reloader-1.0.68"
32-
release: "reloader"
33-
heritage: "Helm"
34-
app.kubernetes.io/managed-by: "Helm"
35-
group: com.stakater.platform
36-
provider: stakater
37-
version: v1.0.68
3816
spec:
3917
containers:
4018
- image: "ghcr.io/stakater/reloader:v1.0.68"
@@ -68,4 +46,4 @@ spec:
6846
securityContext:
6947
runAsNonRoot: true
7048
runAsUser: 65534
71-
serviceAccountName: reloader-reloader
49+
serviceAccountName: reloader-reloader

‎deployments/kubernetes/manifests/serviceaccount.yaml

+1-10
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,5 @@
33
apiVersion: v1
44
kind: ServiceAccount
55
metadata:
6-
annotations:
7-
meta.helm.sh/release-namespace: "default"
8-
meta.helm.sh/release-name: "reloader"
9-
labels:
10-
app: reloader-reloader
11-
chart: "reloader-1.0.68"
12-
release: "reloader"
13-
heritage: "Helm"
14-
app.kubernetes.io/managed-by: "Helm"
156
name: reloader-reloader
16-
namespace: default
7+
namespace: default

0 commit comments

Comments
 (0)
Please sign in to comment.