Add all options with our defaults to reusable workflow #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaxel
reviewed
Apr 24, 2024
0x46616c6b
force-pushed
the
Add-all-options-with-our-defaults-to-reusable-workflow
branch
from
7494cdd
to
501cd6b
Compare
0x46616c6b
force-pushed
the
Add-all-options-with-our-defaults-to-reusable-workflow
branch
from
501cd6b
to
b54f9c7
Compare
flaxel
approved these changes
Apr 25, 2024
0x46616c6b
deleted the
Add-all-options-with-our-defaults-to-reusable-workflow
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
I added all possible options from the
gitops-actionto the workflow with our defaults. This should be downward compatible and gives us the possibility to remove "our" defaults from the actions themselves.Checklist