Support GitHub Apps for GitOps Workflow #243
Conversation
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
Not sure why we need the actions/checkout here
There was a problem hiding this comment.
If you want to start the action, you want to get the code of the repo where you execute this action. In this repo, you have the Dockerfile, etc. Without this action, you will get a not-found exception for several files. 😆 If you are unsure, feel free to test your solution. You can use the branch name as your new version. 🙌
There was a problem hiding this comment.
Make sense. I totally forgot that the workflow replaces the entire job content where normally the checkout happens.
0x46616c6b
force-pushed
the
Support-GitHub-Apps-for-GitOps-Workflow
branch
2 times, most recently
from
51d812d
to
52c718c
Compare
| # optional: organization of the gitops repository, default: github.repository_owner | ||
| gitops-organization: <your-organization> |
There was a problem hiding this comment.
Out of interest: What is a use case where this should differ? 🤔
There was a problem hiding this comment.
The actions/create-github-app-token action needs an owner to set the correct scope for the token. Otherwise, the token is only granted for the current repository. But you want to push to another repository (inside of your organization). Therefore, you need to be able to configure them. Otherwise, people outside of Staffbase can't use that workflow.
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
If you want to start the action, you want to get the code of the repo where you execute this action. In this repo, you have the Dockerfile, etc. Without this action, you will get a not-found exception for several files. 😆 If you are unsure, feel free to test your solution. You can use the branch name as your new version. 🙌
0x46616c6b
force-pushed
the
Support-GitHub-Apps-for-GitOps-Workflow
branch
from
52c718c
to
0b772bf
Compare
Type of Change
Description
Checklist