Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Extend release drafter #212

Merged
merged 2 commits into from Jan 15, 2024
Merged

馃帹 Extend release drafter #212

merged 2 commits into from Jan 15, 2024

Conversation

flaxel
Copy link
Contributor

@flaxel flaxel commented Jan 15, 2024

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

  • add explicit secrets to release drafter
  • add hint for GITHUB_TOKEN limitations

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@flaxel flaxel added enhancement New feature or request minor Pull requests with new features labels Jan 15, 2024
@flaxel flaxel requested a review from a team as a code owner January 15, 2024 13:07
@flaxel flaxel merged commit 47cedb5 into main Jan 15, 2024
2 checks passed
@flaxel flaxel deleted the extend-release-drafter branch January 15, 2024 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
@0x46616c6b
Copy link
Contributor

Sorry for jumping in so late, but I am not happy with this implementation. The default behavior was to use the GitHub Token without it being provided by the calling workflow. Now we need to update the workflows everywhere. Can we switch the behavior to use the GitHub Token by default and only use the app credentials if they are provided? What was the purpose of removing that default setting?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request minor Pull requests with new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants