Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto-merge for dependency bumps with major version 0 #204

Merged

Conversation

arblitroshani
Copy link
Contributor

@arblitroshani arblitroshani commented Nov 17, 2023

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

This PR restricts the condition for performing dependency auto-merge by excluding dependencies with major version 0.

Done to adhere to semantic versioning guidelines, which state that patch and minor bumps in dependencies with major version 0 can potentially contain breaking changes.

https://semver.org/#spec-item-4

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

Done to adhere to semantic versioning guidelines, which state that patch and minor bumps in
dependencies with major version 0 can potentially contain breaking changes.

https://semver.org/#spec-item-4
Copy link
Contributor

github-actions bot commented Nov 17, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@arblitroshani arblitroshani added dependencies Pull requests that update an action file minor Pull requests with new features labels Nov 17, 2023
@arblitroshani
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 17, 2023
@arblitroshani arblitroshani marked this pull request as ready for review November 17, 2023 14:15
@arblitroshani arblitroshani requested a review from a team as a code owner November 17, 2023 14:15
@flaxel flaxel added enhancement New feature or request patch Pull request with little updates and removed dependencies Pull requests that update an action file minor Pull requests with new features labels Nov 17, 2023
@arblitroshani arblitroshani merged commit fe66996 into main Nov 20, 2023
2 checks passed
@arblitroshani arblitroshani deleted the disable-automerge-for-major-version-0-dependency-bumps branch November 20, 2023 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request patch Pull request with little updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants