Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add "Do not Merge" Workflow #111

Merged
merged 12 commits into from Apr 25, 2024
Merged

✨ Add "Do not Merge" Workflow #111

merged 12 commits into from Apr 25, 2024

Conversation

stefanmeschke
Copy link
Member

@stefanmeschke stefanmeschke commented Apr 4, 2023

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@stefanmeschke
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 4, 2023
@stefanmeschke stefanmeschke added do not merge Pull requests that should not be merged minor Pull requests with new features and removed do not merge Pull requests that should not be merged labels Apr 4, 2023
Copy link
Contributor

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to also add a comment when the PR is blocked with a small explanation about the why and that it will rechecked when the label is removed. When the label is not present the comment could be deleted.

I have some good experience with that action: https://github.com/peter-evans/create-or-update-comment

.github/workflows/do-not-merge.yml Outdated Show resolved Hide resolved
.github/workflows/do-not-merge.yml Outdated Show resolved Hide resolved
.github/workflows/do-not-merge.yml Outdated Show resolved Hide resolved
@flaxel flaxel added the enhancement New feature or request label May 1, 2023
@flaxel
Copy link
Contributor

flaxel commented Apr 8, 2024

@0x46616c6b 0x46616c6b marked this pull request as ready for review April 25, 2024 09:57
@0x46616c6b 0x46616c6b requested a review from a team as a code owner April 25, 2024 09:57
@0x46616c6b 0x46616c6b changed the title ✨ do not merge action ✨ Add "Do not Merge" Workflow Apr 25, 2024
@0x46616c6b 0x46616c6b force-pushed the do-not-merge-action branch 5 times, most recently from b99a7a6 to fabeecb Compare April 25, 2024 11:29
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/template_merge_block.yml Outdated Show resolved Hide resolved
@0x46616c6b 0x46616c6b force-pushed the do-not-merge-action branch 2 times, most recently from ea4de70 to f9a36fc Compare April 25, 2024 11:36
@0x46616c6b 0x46616c6b requested a review from flaxel April 25, 2024 11:57
@0x46616c6b 0x46616c6b merged commit d977ad9 into main Apr 25, 2024
2 checks passed
@0x46616c6b 0x46616c6b deleted the do-not-merge-action branch April 25, 2024 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request minor Pull requests with new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants