Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable golangci linters #7729

Open
20 tasks
janisz opened this issue Sep 7, 2023 · 2 comments
Open
20 tasks

Enable golangci linters #7729

janisz opened this issue Sep 7, 2023 · 2 comments

Comments

@janisz
Copy link
Contributor

janisz commented Sep 7, 2023

Enable following checks in .golangci.yml.
Every PR should fix one rule. There is a chance that some rules are already fixed and we only need to enable them.
After including new rule, please ensure make golangci-lint is passing if there are errors please fix them.
In case there are too many errors feel free to make smaller PRs and enable rules only for specific subdirs (example) or excluding tests (example).

@pawiecz
Copy link

pawiecz commented Sep 28, 2023

Is there a priority or a preferred order for enabling linters listed above? Or should these just be enabled one by one in given order?

@janisz
Copy link
Contributor Author

janisz commented Oct 5, 2023

@pawiecz There is no priority. You can choose whatever you want. What's more some of the checks might be better to split into multiple PRs and enable directory by directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants