Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a real matrix to Static analysis workflow #613

Merged
merged 9 commits into from
Jul 30, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 29, 2023

  • Added a real 3×2×1×1 matrix + 3 "includes"
  • Move database options to db-options
  • PHP 8.0 + MariaDB was excluded - Should I exclude it now?

@szepeviktor szepeviktor marked this pull request as ready for review July 29, 2023 15:43
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 29, 2023

Note

@staabm You may repeat this with unit tests workflows.

@staabm
Copy link
Owner

staabm commented Jul 30, 2023

PHP 8.0 + MariaDB was excluded - Should I exclude it now?

If green - we can keep them


Could you have a look at the failling jobs?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 30, 2023

Could you have a look at the failling jobs?

Those jobs are in the unit test workflow. I leave them 101% up to you.

@szepeviktor szepeviktor changed the title Fix MariaDB health check Add a real matrix to Static analysis workflow Jul 30, 2023
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 30, 2023

@TomasVotruba uses this mysterious .72 tail on his versions.

tomasvotruba/unused-public 0.2.0.72 requires php ^7.2 || 8.0.*
 -> your php version (8.3.0-dev) does not satisfy that requirement.

How to get the .72-less version?

@staabm
Copy link
Owner

staabm commented Jul 30, 2023

I think the problem is that there currently is no nette/utils release which supports PHP8.3

nette/utils#297

@staabm staabm merged commit 0e5a449 into staabm:main Jul 30, 2023
29 checks passed
@staabm
Copy link
Owner

staabm commented Jul 30, 2023

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants