Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to use resvg 0.33.0 #79

Merged
merged 2 commits into from May 20, 2023
Merged

Conversation

mfzl
Copy link
Contributor

@mfzl mfzl commented May 18, 2023

resvg did some major updates recently. This makes it compile with the newest version at this time.

The test images had only few pixel differences, probably due to changes in rendering. I've updated those images with very small differences.

@ssssota
Copy link
Owner

ssssota commented May 18, 2023

Thanks for your contribution!
I'll check it later.

@ssssota
Copy link
Owner

ssssota commented May 19, 2023

@mfzl Can you rebase the master branch?

@mfzl
Copy link
Contributor Author

mfzl commented May 19, 2023

@ssssota done

@mfzl
Copy link
Contributor Author

mfzl commented May 19, 2023

@ssssota the action failure seems due to an issue with wasm-pack version. Shall I bump it to 0.11.1 in this PR. It doesn't have the issue

@mfzl
Copy link
Contributor Author

mfzl commented May 19, 2023

I've pushed the update, you can have a look. I'll revert if necessary

Copy link
Owner

@ssssota ssssota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Once again, thank you!

@ssssota ssssota merged commit fcd914c into ssssota:main May 20, 2023
8 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants