Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSS and JS tokenizers + related sniffs #2448

Closed
gsherwood opened this issue Mar 19, 2019 · 4 comments
Closed

Remove CSS and JS tokenizers + related sniffs #2448

gsherwood opened this issue Mar 19, 2019 · 4 comments
Projects
PHPCS v4 Development
Milestone
4.0.0

Comments

@gsherwood
Copy link
Member

Maintaining these tokenizers takes time, and they are not able to parse modern CSS and JS anyway, so they are pretty much useless. It's time to remove them.
@gsherwood gsherwood added this to the 4.0.0 milestone Mar 19, 2019
@gsherwood gsherwood added this to Backlog in PHPCS v4 Development via automation Mar 19, 2019
@seriquynh
Copy link

seriquynh commented Mar 19, 2019 •
edited

I absolutely agree. The modern software world contains various tools to check CSS and JS styles. PHP_CodeSniffer should focus on the right thing - the PHP programming language.

@jrfnl jrfnl mentioned this issue May 19, 2019
Closed
3 tasks
@gsherwood gsherwood mentioned this issue Aug 26, 2019
Closed
@rebeccahum rebeccahum mentioned this issue Aug 27, 2019
Open
@GaryJones
Copy link
Contributor

Is there a ballpark date for when 4.0.0 is expected to drop? Months? Years?

@gsherwood
Copy link
Member Author

Is there a ballpark date for when 4.0.0 is expected to drop? Months? Years?

It's not years away, but it wont be this year. After 3.5.0 is released (hopefully in a few weeks) I'll get started on a 4.0 branch to begin the changes.

Even after 4.0 is release, I'll still support version 3 for a while with bug fixes and critical changes. How long depends on how many there are, but I try not to drop support until the bug reports for an old version basically stop coming in.

This was referenced Dec 27, 2019
Closed
Closed
@VincentLanglet VincentLanglet mentioned this issue Jan 4, 2020
Closed
@gsherwood gsherwood moved this from Backlog to Selected for Development in PHPCS v4 Development Jan 31, 2020
gsherwood added a commit that referenced this issue Jan 31, 2020
@gsherwood
Removed support for checking JS and CSS files (ref #2448)
ea52e7b
@gsherwood
Copy link
Member Author

I've now removed the tokenizers + all non-PHP checks inside sniffs + all JS/CSS test files + changed the ---extensions CLI arg to not allow passing a tokenizer.

PHPCS v4 Development automation moved this from Selected for Development to Ready for Release Jan 31, 2020
@gsherwood gsherwood mentioned this issue Oct 19, 2021
Closed
@gsherwood gsherwood mentioned this issue Sep 12, 2022
Closed
@DannyvdSluijs DannyvdSluijs mentioned this issue Dec 4, 2023
Merged
11 tasks
@kczx3 kczx3 mentioned this issue Dec 29, 2023
Open
jrfnl added a commit to PHPCSStandards/PHP_CodeSniffer that referenced this issue Jan 15, 2024
@jrfnl
Soft deprecate all sniffs which are to be removed in PHPCS 4.0
6b0ba5d 
The deprecation of these sniffs was previously already announced in:
* CSS/JS specific sniffs: squizlabs/PHP_CodeSniffer#2448
* MySource standard: squizlabs/PHP_CodeSniffer#2471

This commit _soft_ deprecates these sniffs with a `@deprecated` annotation. This will get a mention in the changelog.

Hard deprecation will follow in a future 3.x minor as per 188.
This was referenced Jan 15, 2024
Merged
Merged
jrfnl added a commit to PHPCSStandards/PHP_CodeSniffer that referenced this issue Jan 19, 2024
@jrfnl
Soft deprecate all sniffs which are to be removed in PHPCS 4.0
0f18ec6 
The deprecation of these sniffs was previously already announced in:
* CSS/JS specific sniffs: squizlabs/PHP_CodeSniffer#2448
* MySource standard: squizlabs/PHP_CodeSniffer#2471

This commit _soft_ deprecates these sniffs with a `@deprecated` annotation. This will get a mention in the changelog.

Hard deprecation will follow in a future 3.x minor as per 188.
@jrfnl jrfnl mentioned this issue Jan 19, 2024
Open
12 tasks
GaryJones added a commit to Automattic/VIP-Coding-Standards that referenced this issue Feb 16, 2024
@GaryJones
Soft deprecate sniffs which will be removed for PHPCS 4.0
077c7b2 
CSS/JS tokenizers will be removed for PHPCS 4: squizlabs/PHP_CodeSniffer#2448

This commit _soft_ deprecates these sniffs with a `@deprecated` annotation. They will also get a mention in the changelog.

Hard deprecation using the PHPCS 3.9.0 native handling of deprecated sniffs will follow.

See #442.
@jonathanbossenger jonathanbossenger mentioned this issue Feb 29, 2024
Closed
DannyvdSluijs pushed a commit to DannyvdSluijs/PHP_CodeSniffer_Continuation that referenced this issue Apr 29, 2024
@jrfnl @DannyvdSluijs
Soft deprecate all sniffs which are to be removed in PHPCS 4.0
d25babf 
The deprecation of these sniffs was previously already announced in:
* CSS/JS specific sniffs: squizlabs/PHP_CodeSniffer#2448
* MySource standard: squizlabs/PHP_CodeSniffer#2471

This commit _soft_ deprecates these sniffs with a `@deprecated` annotation. This will get a mention in the changelog.

Hard deprecation will follow in a future 3.x minor as per 188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PHPCS v4 Development
  
Ready for Release
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@GaryJones @gsherwood @seriquynh