Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese and Japanese Characters Support #240

Open
Colgrave34 opened this issue Feb 28, 2024 · 6 comments
Open

Chinese and Japanese Characters Support #240

Colgrave34 opened this issue Feb 28, 2024 · 6 comments

Comments

@Colgrave34
Copy link

Hello,
Does Halloy support Chinese and Japanese characters at the moment?
I have tried to change the fonts, but it always ends up like this:
Screenshot from 2024-02-28 14-00-56
Another question is, where is the fonts storage or located, or is it from the system fonts?
Thanks.
I'm on Fedora 39 running Flatpak, font was Fira Code.

@Colgrave34
Copy link
Author

Colgrave34 commented Feb 28, 2024

Further investigation, Chinese character works fine on Windows.
Screenshot 2024-02-28 170113
I don't own a Mac, so I have no idea if they work.

@YouFoundAlpha
Copy link
Contributor

Hello @Colgrave34 !
I found this solution that might work for the Fira Code font if you want to see Japanese Characters tonsky/FiraCode#620 (comment)

@Colgrave34
Copy link
Author

Hello @YouFoundAlpha !
Thanks a lot for looking, I have installed the font system wide and user wide, it's still not picking up the font, as showing below. ( I was typing japanese). One more factor is that I am using flatpak, is that effect anything?
20240329_17h21m56s_grim

@YouFoundAlpha
Copy link
Contributor

Hello @YouFoundAlpha ! Thanks a lot for looking, I have installed the font system wide and user wide, it's still not picking up the font, as showing below. ( I was typing japanese). One more factor is that I am using flatpak, is that effect anything? 20240329_17h21m56s_grim

I don't know if that's an issue
I build it from source
I looked around in the source code and found that you could change the font by changing the path to the fonts in the font.rs file but I haven't tried modifying it yet

@Colgrave34
Copy link
Author

I built Halloy from source, and the chinese font got picked up right the way, without me setting it in the config. I believe this is a Flatpak spcific issue...
The Font config wasn't really clear either, so maybe I did something wrong.
20240404_12h38m35s_grim

@YouFoundAlpha
Copy link
Contributor

I built Halloy from source, and the chinese font got picked up right the way, without me setting it in the config. I believe this is a Flatpak spcific issue... The Font config wasn't really clear either, so maybe I did something wrong. 20240404_12h38m35s_grim

The Chinese font that you are seeing is a fallback font because Fira Code doesn't have Chinese characters in it (tonsky/FiraCode#620 (comment)) according to the creator of it
and the default font for Halloy doesn't have Japanese characters in it from what I've seen in the source code of it (https://github.com/be5invis/Iosevka)
Here's the the link to the full list of characters that the default font of Halloy has (https://typeof.net/Iosevka/specimen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants