Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling privacy plugin throws an error #7624

Closed
4 tasks done
dickermoshe opened this issue Oct 15, 2024 · 4 comments
Closed
4 tasks done

Disabling privacy plugin throws an error #7624

dickermoshe opened this issue Oct 15, 2024 · 4 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@dickermoshe
Copy link

Context

No response

Bug description

If you define that privacy is explicitly disabled, mkdocs serve crashes:

plugins:
  - privacy:
      enabled: false

Error:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/mkdocs/livereload/__init__.py", line 211, in _build_loop
    self.builder()
  File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 67, in builder
    build(config, serve_url=None if is_clean else serve_url, dirty=is_dirty)
  File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/build.py", line 319, in build
    env = config.plugins.on_env(env, config=config, files=files)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/mkdocs/plugins.py", line 599, in on_env
    return self.run_event('env', env, config=config, files=files)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/mkdocs/plugins.py", line 566, in run_event
    result = method(item, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/material/plugins/privacy/plugin.py", line 152, in on_env
    wait(self.pool_jobs)
         ^^^^^^^^^^^^^^
AttributeError: 'PrivacyPlugin' object has no attribute 'pool_jobs'

Related links

Reproduction

9.5.41-explicit-disable-privacy.zip

Steps to reproduce

  1. mkdocs serve
  2. Crashes instantly

Browser

Chrome

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting. It's a 9.5.41 regression. Fixed in e2c621f.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open labels Oct 15, 2024
@dickermoshe
Copy link
Author

Thanks!
What is your release cycle? When will I see this on docker hub?

@squidfunk
Copy link
Owner

Yes, it will be part of 9.5.42. Usually once a week. We just released 9.5.41 yesterday, and this is not a fatal bug, so give it a few days. You can always use Material for MkDocs from git, to use the version that contains the fix.

@squidfunk
Copy link
Owner

Released as part of 9.5.42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants