Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tooltip style of the logo is lost in instant loading mode #7619

Closed
4 tasks done
Xiaokang2022 opened this issue Oct 15, 2024 · 2 comments
Closed
4 tasks done

The tooltip style of the logo is lost in instant loading mode #7619

Xiaokang2022 opened this issue Oct 15, 2024 · 2 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@Xiaokang2022
Copy link

Context

Python: 3.13.0
OS: Windows11 23H2

Bug description

With the Instant Loading mode, the style of the logo's tooltip is only correct the first time, and will lose the style after clicking on another page.

Related links

Reproduction

9.5.40-logo-bug.zip

Steps to reproduce

  1. Refresh the current page
  2. Check that the style of the logo's tooltip is correct
  3. Click on a different page or click on the page again and check again
  4. Styles are missing

Browser

Edge

Before submitting

@squidfunk
Copy link
Owner

squidfunk commented Oct 15, 2024

Fixed in 649abd2. We must remount the header component on instant navigation to account for tooltips that are not hidden in nested components in the header (like repository or search). This commit moves the header to the $content observable chain, which will now update correctly.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open labels Oct 15, 2024
@squidfunk
Copy link
Owner

Released as part of 9.5.41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants