Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant previews: default configuration adds previews for all pages #7052

Closed
4 tasks done
jonaharagon opened this issue Apr 16, 2024 · 2 comments
Closed
4 tasks done
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@jonaharagon
Copy link
Sponsor

Context

I'll open a separate bug for you regarding #7051 (comment) if this makes it easier to track of.

Bug description

Enabling the material.extensions.preview extension makes mkdocs show instant previews on all internal links. I assume it is treating targets as all pages by default, instead of no pages.

markdown_extensions:
  - material.extensions.preview:

Related links

Reproduction

9.5.18+insiders.4.53.6-preview-on-all-links.zip

Steps to reproduce

  1. Enable material.extensions.preview without any options.
  2. Add internal link to a page without setting the data-preview attribute on it.
  3. That link gets the instant preview treatment anyways.

Browser

No response

Before submitting

@squidfunk squidfunk added the bug Issue reports a bug label Apr 16, 2024
@squidfunk squidfunk changed the title The preview markdown extension adds previews to all internal links by default Instant previews: default configuration adds previews for all pages Apr 16, 2024
@squidfunk
Copy link
Owner

Thanks for reporting! Fixed in c5989cc.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Apr 25, 2024
@squidfunk
Copy link
Owner

Released as part of 9.5.19+insiders-4.53.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants