Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palette toggle's keyboard operation is confusing #7003

Closed
4 tasks done
cmuncharaz opened this issue Apr 1, 2024 · 2 comments
Closed
4 tasks done

Color palette toggle's keyboard operation is confusing #7003

cmuncharaz opened this issue Apr 1, 2024 · 2 comments
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open

Comments

@cmuncharaz
Copy link

Context

No response

Bug description

The color palette toggle looks like a button, and sighted keyboard users would expect to activate it using the Enter or Space keys. However, the toggle is not responding to those keys. Underneath, this is implemented as a set of radio buttons and is operated using the arrow keys. This is not evident to sighted keyboard users, who might think the "button" is not working.

Related links

Reproduction

9.5.16-color-palette-keyboard-operation.zip

Steps to reproduce

  1. Install Material for MkDocs, create a site with the minimal configuration, set the color palette toggle, serve Material for MkDocs, point your browser to localhost:8000.
  2. Use the Tab key to set the keyboard focus indicator on the color palette toggle.
  3. Hit Enter or Space to activate it.

Browser

No response

Before submitting

@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Apr 1, 2024
@squidfunk
Copy link
Owner

Thanks for suggesting. Fixed in 78e93ac. Pressing Enter now allows to cycle through the palettes. We're likely going to completely rewrite this component as part of our upcoming rebrush / facelift that we're planning to do later this year, but for the time being this should be a good bandaid.

@squidfunk squidfunk added change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Apr 2, 2024
@squidfunk
Copy link
Owner

Released as part of 9.5.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants