Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress "Continue Reading" from blog entries on index pages if they do not have an excerpt marker #6783

Closed
4 tasks done
wez opened this issue Feb 13, 2024 · 2 comments
Closed
4 tasks done
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open

Comments

@wez
Copy link

wez commented Feb 13, 2024

Context

See the discussion in #6759

Description

If I use the marker to define the cut point for an excerpt, the index page works as I'd expect; the content before the marker is used as an excerpt and then the "Continue Reading" link takes the visitor to the full content for that post. All good.

However, if I omit the marker then the entire content is used in the index page (which is what I'd expect), AND "Continue Reading" is shown below it. That gives the visitor the expectation that there is more to read in that case, but when they click through they are disappointed.

I propose that the "Continue Reading" link be omitted in that second case.

Related links

Use Cases

See discussion in #6759

Visuals

No response

Before submitting

@squidfunk squidfunk added the change request Issue requests a new feature or improvement label Feb 14, 2024
@squidfunk
Copy link
Owner

Fixed in b7fc7ba. The post.more attribute now contains the content after the post separator. Template authors can decide to render the entire content on the overview page and make it expandable. This allows for more flexibility than just providing a boolean indicator, which is why we went for it. The continue reading link should now be automatically removed if there is no separator and/or nothing more to read (= the separator is at the very end of the Markdown).

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Feb 15, 2024
@squidfunk
Copy link
Owner

squidfunk commented Feb 19, 2024

Released as part of 9.5.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants