Instant preview misplacement with tabs above

[pawamoy]

Context

Reported here first: #6704 (comment).

Bug description

Instant previews enabled globally with navigation.instant.preview.

When there are tabs above a previewable link, the preview windows can be misplaced: it seems the preview windows position are calculated once, when the page loads. If I change tabs above previewable links, and these tabs have different heights, then all previewable links after these tabs have misplaced preview windows. If I reload the page, staying on the second tab, positions are recalculated correctly. Well, these are assumptions, you'll know better what's really happening 🙂

Related links

• Reporting a bug
• Instant previews

Reproduction

9.5.7+insiders.4.52.1-instant-preview-misplacement.zip

Steps to reproduce

• Serve the given reproduction and go to the home page.
• Assert both previewable links have correct preview window positions.
• Now change to second tab in the "Tabs before" section.
• Assert that first link preview is still correct, but second link preview isn't. Increase or reduce space below second link (by scrolling) to see both behaviors (when there's enough space below the link to show the preview window, or not).

Browser

Firefox

Before submitting

• I have read and followed the bug reporting guidelines.
• I have attached links to the documentation, and possibly related issues and discussions.
• I assure that I have removed all customizations before submitting this bug report.
• I have attached a .zip file with a minimal reproduction.

[squidfunk]

Fixed in b4b1a42. So, we forgot to recompute the absolute element offset after the tooltip was activated for the first time. This should now be fixed with the latest commit, albeit we didn't yet find the best method of accurately tracking element offsets. We'll definitely do a small refactoring once we could smooth the rough edges of the new tooltips implementation, but for the time being, the issue should be resolved ☺️

[squidfunk]

Released as part of 9.5.8+insiders-4.52.2.