Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags update breaks macros plugin #6594

Closed
4 tasks done
Vasperous opened this issue Jan 4, 2024 · 5 comments
Closed
4 tasks done

Tags update breaks macros plugin #6594

Vasperous opened this issue Jan 4, 2024 · 5 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@Vasperous
Copy link

Context

No response

Bug description

After updating to the latest Material release (9.5.3+insiders.4.49.0) I noticed that the macros plugin was no longer working. For example, {{x}} was being displayed instead of the definition of X (which is an icon).

By removing the tags plugin I was able to see the macros plugin work as expected.

Related links

Reproduction

9.5.3+insiders.4.49.0-macros-tags-issue.zip

Steps to reproduce

  1. Create a new project
  2. Add macros to the plugins list
  3. Add the macros file and update the mkdocs.yaml
  4. Build documentation and see macros plugin working
  5. Add tags plugin
  6. Check rebuilt documentation

Browser

Other

Before submitting

@jaceklaskowski
Copy link

Confirmed. Same experience and had to pin mkdocs-material version to 9.5.2-insiders-4.47.1. Glad I'm not alone and hoping for a quick fix ❤️

@squidfunk
Copy link
Owner

Thanks for reporting! I'll look into it.

@squidfunk squidfunk added the bug Issue reports a bug label Jan 5, 2024
@squidfunk
Copy link
Owner

Fixed in 39ea162.

This should fix interop with all third-party plugins that alter the Markdown of a page, not only with the macros plugin.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jan 5, 2024
@squidfunk
Copy link
Owner

Released as part of 9.5.3+insiders-4.49.1.

@jaceklaskowski
Copy link

Confirmed. Works like a charm! Danke schon mein Freund for such a quick turnaround! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

3 participants