Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content.tooltips feature breaks abbreviation hover in tab titles #6488

Closed
4 tasks done
SerTetora opened this issue Dec 11, 2023 · 8 comments
Closed
4 tasks done

content.tooltips feature breaks abbreviation hover in tab titles #6488

SerTetora opened this issue Dec 11, 2023 · 8 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@SerTetora
Copy link

Context

No response

Bug description

I'm trying to use improved tooltips within content tabs.

with:

features:
    - content.tooltips

image
on scroll
image

without:
image

mkdocs.yml

site_name: My Docs
docs_dir: docs/

nav: 
  - index.md

theme:
  name: material
  features:
    - content.tooltips

plugins:
  - info

markdown_extensions:
  - abbr
  - attr_list
  - pymdownx.snippets:
      auto_append:
        - docs/includes/abbreviations.md
  - pymdownx.superfences
  - pymdownx.tabbed:
      alternate_style: true

docs/index.md

# Welcome to MkDocs

=== "FEM"
    lorem FEM

=== "CFD"
    ipsum CFD

docs/includes/abbreviations.md

*[FEM]: Finite Element Method
*[CFD]: Computational Fluid Dynamic

Related links

Reproduction

9.5.1-tooltips_reproduction.zip

Steps to reproduce

Use improved tooltips within content tabs.

Browser

Chrome

Before submitting

@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Dec 11, 2023
@squidfunk squidfunk added bug Issue reports a bug and removed needs investigation Issue must be investigated by the maintainers labels Jan 19, 2024
@Andre601
Copy link
Contributor

I am not sure if this is related, but I encounter a position issue with tooltips.

Namely, when I use inline admonition blocks (inline end type) and a text with abbreviation is split up by it (or otherwise moved by it) does the tooltip not recognize it and display it at a completely wrong position.

My minimal reproduction:
9.5.5-tooltips-position-issue.zip

@squidfunk
Copy link
Owner

squidfunk commented Jan 26, 2024

@SerTetora thanks for reporting. We've just implemented a new tooltip positioning logic for the brand new footnote tooltips (see demo on Twitter), which does not suffer from the problems reported. We're in the process of replacing the previous tooltip positioning with the new implementation, which should solve this issues as well.

@squidfunk
Copy link
Owner

Note that this problem is already fixed in Insiders, as we swapped out the tooltip implementation to implement footnote tooltips and instant previews. Once we've collected a little more feedback on those features, we'll back port the new business logic which we confirmed to also fix this problem ☺️

@squidfunk squidfunk changed the title Overflow on improved tooltips inside content tabs content.tooltips feature breaks abbreviation hover in tab titles Apr 4, 2024
@squidfunk
Copy link
Owner

Fixed in e15518c – I backported the new tooltip implementation from Insiders in the refactor/tooltip-positioning branch! If you could spare a few minutes and check whether this fixes your issue, we can release it in the next days ☺️ Install with:

pip install git+https://github.com/squidfunk/mkdocs-material.git@refactor/tooltip-positioning

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Apr 14, 2024
@SerTetora
Copy link
Author

Hi, @squidfunk, it works for me. Many thanks for fixing this!

@squidfunk
Copy link
Owner

Awesome, thanks for testing!

@Andre601
Copy link
Contributor

Can also confirm that it seems fixed now.

@squidfunk
Copy link
Owner

Released as part of 9.5.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

3 participants