- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Logo overlap in social card #6475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting. A mere |
Thanks for the reproduction. So I read this only happens in Insiders? |
Okay, this is still not a minimal reproduction. It contains your entire site. Please provide a minimal reproduction that only includes the minimal set of files that showcases the error. It's not runnable:
|
So, does this solve your problem? I'm not sure I understand your last message... If not, we definitely need a minimal reproduction. Also note that the social plugin was entirely rewritten in Insiders. It has no commonalities with the community edition. On a further note, |
Oh, indeed the option is insiders only which is why it has no effect on the latest public release https://squidfunk.github.io/mkdocs-material/plugins/social/#option.logo Sure, I'll put together a small example. I literally just want that logo to be replaced by the path to image |
Thank you. Next time, you can save us both a lot of time providing the minimal reproduction when creating the issue. Please understand that we can make no exceptions, as we already invest a lot of time into providing free support. |
I feel like this is such a fundamental feature and so simple that I must be doing something wrong in that example I just gave you. Do you think perhaps SVGs aren't supported for that field and maybe I should use a different format? |
Is there any reason you are not using the info plugin as required? The info plugin collects all installed dependencies and information on the environment that is missing in your reproduction... You know, I'm happy to help you, but we have processes for a reason. I'm feeling really sorry to be so upfront, but having to ask for each and every bit of information is a very inefficient use of my time. |
I can finally reproduce the error. |
I'm sorry! I did the info plugin originally but you tried the archive and said it was not reproducible so I had to manually take away everything. Is that not what you meant for me to do? |
A minimal reproduction should always be built from scratch, as described in our documentation. |
Fixed in |
Keeping open until released. |
Released as part of 9.5.2+insiders-4.47.1. |
Context
No response
Bug description
When a custom logo is set, the site logo overrides it:
Related links
https://squidfunk.github.io/mkdocs-material/plugins/social/#option.logo
Reproduction
Steps to reproduce
https://github.com/pypa/hatch/blob/master/mkdocs.yml
Browser
Chrome
Before submitting
The text was updated successfully, but these errors were encountered: