-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting dev_addr
to localhost
breaks navigation.instant
as of 9.4.3
#6204
Comments
What operating system are you on? Can you confirm that I built your site but running |
I'm on macOS 13.6.
|
Doesn't make sense to me. I also could not reproduce on my machine (Ubuntu 22.04, kernel 5.15.0-86-generic, Python 3.10.12, other packages installed latest on a fresh venv). Maybe this is something macOS-specific. Also it would help better if your ZIP contained a minimal reproduction, not something with poetry or nox or whatever. |
The zip file itself has a
Perhaps the auto-reloader/server works differently on macOS? I've seen similar differences on Flask and other similar auto-reload projects in the past. Since it worked on 9.4.2 and broke specifically starting at 9.4.3, I thought it was worth reporting in case there is something underlying. If the maintainer would like to close this issue, I'm also fine with that as well, since I was able to fix my particular issue by using |
You skipped the only bold word in my response: Please provide a minimal reproduction so others can actually look into it without various plugins interfering. Also, I reviewed Based on those reviews, I'm inclined to believe there's something wrong with another component in your setup, and definitely not the theme's fault. Chances are very likely that you upgraded the faulty component along with the theme from 9.4.2 to 9.4.3. |
Thanks @alexvoss and @iBug taking the time to help here. I'm closing this as not reproducible for now. If @johnthagen provides a minimal reproduction that allows us to inspect the error, we can reopen this issue. |
This seems to be fixed when I tried it in |
Context
Originally discussed at
Bug description
Mkdocs has a
dev_addr
configuration.If the user configures this to:
This breaks the
navigation.instant
feature. Clicking on links in the navigation or within the pages will not update the contents on screen correctly.Solution 1
Note, that strictly speaking the Mkdocs docs state that the format should be
IP:Port
, andlocalhost
is not an IP. Moving this to127.0.0.1:8001
fixes this issue, but since it used to work, I thought I'd report to see if there are any other underlying issues to address.Could this instead fail hard with a clear error message?
Solution 2
9.4.2
release does not exhibit this "bug".Related links
Reproduction
9.4.6-dev_addr-localhost-navigation.zip
Steps to reproduce
poetry install
nox -s docs_serve
Browser
Chrome
Before submitting
The text was updated successfully, but these errors were encountered: