-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict with abbreviations, toc extension, and typeset plugin #5579
Comments
Thanks for reporting. So just to be clear – it works if you downgrade to 9.1.14+insiders-4.35.1, right? If so, it is very likely related to the change added in #5536. /cc @pawamoy. |
Thanks for the ping @squidfunk 🙂 |
I think Here is an example heading containing the abbreviation, from OP's repro: <h2 id="othertext-abbreviation-moretext">
OtherText <abbr title="Test abbreviation!">Abbreviation</abbr> MoreText
<a class="headerlink" href="#othertext-abbreviation-moretext" title="Permanent link">¶</a>
</h2> The issue is simply that - title = re.sub(r"^<a.*?>(.*?)<\/a>", r"\1", title)
- title = re.sub(r"<a.*?>.*?<\/a>$", "", title)
+ title = re.sub(r"^<a\s+.*?>(.*?)<\/a>", r"\1", title)
+ title = re.sub(r"<a\s+.*?>.*?<\/a>$", "", title) |
Ah, interesting, thanks for debugging! I'll check that asap! |
Released as part of 9.1.15+insiders-4.35.3! |
Context
Updating to the latest mkdocs-material-insiders breaks some tables of contents on our staging site: https://deploy-preview-2177.preview.privacyguides.dev/en/vpn/#ipv6-support
Bug description
In the Table of Contents with the typeset plugin enabled, if there's an abbreviation in a heading, the abbreviation and any subsequent text doesn't get rendered at all.
If the abbreviation is at the very beginning of the header it does show the entire heading text, but the permalink icon gets erroneously included at the end:
Related links
Reproduction
example.zip
Steps to reproduce
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: