You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Google's Open Sans font package contains several font variations in subdirectories. The code picks the last one that ends in "-Regular.ttf" which returns an arbitrary variation based on the order the OS returns files.
I've implemented a change to the social plugin that specifically matches the -Regular.ttf version in this fork. It uses os.walk() rather than glob() to find the files. Either would probably be fine but I'd implemented it before your fix for the Inter font (#5420 - see related links).
It sounds like work is in progress on the social plugin, so please let me know if you would like me to submit a PR for this or just pick it up yourself.
Thanks for reporting! The social plugin has been entirely rewritten, now even supporting entirely custom layouts, and doesn't suffer from those problems anymore. However, the community edition does, as the code base and solution predates the one we have now, and the new social plugin is currently solely available to sponsors of the project.
If you wish, you can create a PR with your changes, and we can fix the behavior in the community edition.
Context
No response
Bug description
Google's Open Sans font package contains several font variations in subdirectories. The code picks the last one that ends in "-Regular.ttf" which returns an arbitrary variation based on the order the OS returns files.
I've implemented a change to the social plugin that specifically matches the -Regular.ttf version in this fork. It uses
os.walk()
rather thanglob()
to find the files. Either would probably be fine but I'd implemented it before your fix for the Inter font (#5420 - see related links).It sounds like work is in progress on the social plugin, so please let me know if you would like me to submit a PR for this or just pick it up yourself.
Related links
Reproduction
example.zip
Steps to reproduce
If you add
on line 465 of plugin.py then run
mkdocs build
you get the outputIt's an accident of file ordering that the last one is the one we want, and shouldn't be relied upon.
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: