Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insiders only: abbreviations missing bottom border #5159

Closed
3 of 4 tasks
jonaharagon opened this issue Mar 6, 2023 · 3 comments
Closed
3 of 4 tasks

Insiders only: abbreviations missing bottom border #5159

jonaharagon opened this issue Mar 6, 2023 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@jonaharagon
Copy link
Sponsor

jonaharagon commented Mar 6, 2023

Context

No response

Bug description

The insiders stylesheet is different from the public stylesheet:

https://github.com/squidfunk/mkdocs-material-insiders/blob/master/src/assets/stylesheets/main/_typeset.scss#L293-L297

As opposed to:

https://github.com/squidfunk/mkdocs-material/blob/master/src/assets/stylesheets/main/_typeset.scss#L289-L312

It's missing the bottom-border attribute among other things making abbreviations indistinguishable on the site.

Related links

Reproduction

You can see this behavior on your own site: https://squidfunk.github.io/mkdocs-material/reference/tooltips/#adding-abbreviations

Steps to reproduce

  1. Use abbreviations on insiders install

Browser

No response

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting! Likely a regression and definitely a bug.

@squidfunk squidfunk added the bug Issue reports a bug label Mar 6, 2023
@squidfunk
Copy link
Owner

This was accidentally removed in the 9.1.0 merge which included some property reordering due to the switch to a newer stylelint plugin that ensures a unified property order. Fixed in b034cd368.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Mar 6, 2023
@squidfunk
Copy link
Owner

Released as part of 9.1.2+insiders-4.32.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants