Privacy plugin can't handle a large number of external assets

[jonaharagon]

Context

privacyguides/privacyguides.org#2063 (comment)

Bug description

On pages with a lot of external resources or links, the privacy plugin does not download all external assets. This is easily reproduced by just repeating the same emoji a bunch of times:

This is not only dependent on the number of external assets, any regular links to external sites also break external assets that come after them in the document:

Related links

• Reporting a bug

Reproduction

Archive.zip

Steps to reproduce

1. Enable the privacy plugin
2. Load a large number of external images/assets (can be identical)

Browser

No response

Before submitting

• I have read and followed the bug reporting guidelines.
• I have attached links to the documentation, and possibly related issues and discussions.
• I assure that I have removed all customizations before submitting this bug report.
• I have attached a .zip file with a minimal reproduction.

[squidfunk]

Thanks for reporting and the excellent reproduction. Fixed in 7e19ae71f. In fact, it was no concurrency issues as initially suspected. The problem was that the flags passed to re.sub where interpreted as a maximum number of replacements, not as flags, since count is the first parameter in order. This lead to a maximum number of 40 replacements, as I counted.

[squidfunk]

Released as part of 9.1.0+insiders-4.32.2.