Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code selection link sometimes miscalculates the code ID #5066

Closed
4 tasks done
hellt opened this issue Feb 19, 2023 · 3 comments
Closed
4 tasks done

Code selection link sometimes miscalculates the code ID #5066

hellt opened this issue Feb 19, 2023 · 3 comments
Labels
needs reproduction Issue lacks a minimal reproduction .zip file

Comments

@hellt
Copy link
Contributor

hellt commented Feb 19, 2023

Context

website: https://learn.srlinux.dev/get-started/

Bug description

Using insiders 4.32.0 where the code selection feature was released I noticed that while navigating among pages and clicking on code selection sometimes code block ID is detected wrongly.

Related links

Reproduction

I couldn't reproduce this using squidfunk site, but maybe you may get a feeling as to why this could have happened on my website.
Therefore the zip is missing.

2023-02-19_22-15-22.mp4

This video shows that code selection first correctly identified code block ID as 0, then I switched to anther page via the menu element, got back, clicked on code selection again, and Code ID became 12.

Steps to reproduce

Couldn't reproduce on squidfunk's site.
On my site the reproduction steps are:

  1. click on code selection, check the link in the URL input. If correct, change to other page on the site
  2. try 1 again

Browser

Chrome, Safari

Before submitting

@squidfunk
Copy link
Owner

I couldn't reproduce this using squidfunk site, but maybe you may get a feeling as to why this could have happened on my website.

Sorry, but we need a reproduction.

@squidfunk squidfunk added the needs reproduction Issue lacks a minimal reproduction .zip file label Feb 19, 2023
@hellt hellt closed this as completed Feb 19, 2023
@hellt
Copy link
Contributor Author

hellt commented Feb 21, 2023

I pinned it down to navigation.instant. When it is enabled - code IDs get messed up when switching pages.
Could be related to recent issues found in the instant reloading - #5023

@squidfunk
Copy link
Owner

Perfect, thanks for investing the time. Can you provide a reproduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction Issue lacks a minimal reproduction .zip file
Projects
None yet
Development

No branches or pull requests

2 participants