Revert "Move RealCall and RealConnection to loom safe locks" #8367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a673f45.
|
Damn sorry, I merged against the pool warmer changes, thought I got them and obviously missed some |
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
Apr 17, 2024
…8290)" (square#8367) This reverts commit 689d388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8290
Unfortunately I think this PR is missing some
synchronizedblocks that needed to be converted towithLock {}blocks. Mixing and matching the two definitely doesn’t work, and our tests aren’t sophisticated enough to cover that.I think this is a good idea; we just need to be particularly precise with the implementation. Every occurrence of a lock needs to be fixed together; otherwise we split the lock.