Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage of STAR #1572

Merged
merged 2 commits into from
May 26, 2023
Merged

Add usage of STAR #1572

merged 2 commits into from
May 26, 2023

Conversation

Omico
Copy link
Contributor

@Omico Omico commented May 25, 2023

Improvement of #1554.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@JakeWharton
Copy link
Collaborator

I think if we're going to start expanding the docs I would prefer a dedicate page on modeling types. This would cover creating classes, parameterized types, wildcard types, parsing types from reflection/metadata/strings, referencing other generated types, using types to create specs, etc.

The giant index page is a holdover from when all this content was in the README and it doesn't quite translate to the web.

@Omico
Copy link
Contributor Author

Omico commented May 25, 2023

I think if we're going to start expanding the docs I would prefer a dedicate page on modeling types. This would cover creating classes, parameterized types, wildcard types, parsing types from reflection/metadata/strings, referencing other generated types, using types to create specs, etc.

The giant index page is a holdover from when all this content was in the README and it doesn't quite translate to the web.

I completely agree with you. We can make further improvements in other PRs.

@Egorand Egorand merged commit 2ba85bf into square:master May 26, 2023
@Egorand Egorand mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants