Support "UPDATE" statement in "WITH" subquery

[nicksrandall]

I was getting an error trying to parse this query with postgres:

WITH "result" AS (
  UPDATE
    "Hero"
  SET
    "name" = 'Captain America',
    "number_of_movies" = "number_of_movies" + 1
  WHERE
    "secret_identity" = 'Sam Wilson'
  RETURNING
    "id",
    "name",
    "secret_identity",
    "number_of_movies"
)
SELECT
  json_build_object('data', json_build_object('update', (
        SELECT
          json_agg("result")
        FROM "result")));

[ankrgyl]

Thanks so much for the contribution @nicksrandall! Could you add some tests that demonstrate the new behavior?

[ankrgyl]

Looks good to me, although the test could still be a bit better.

@alamb will leave it up to you on whether to push on that!

[ankrgyl]

Generally it's best to test across dialects, using the testing helpers (e.g. see test_parse_limit earlier in the file). In this case, the change itself has little to do with the dialect itself, so I'm not particularly concerned by it.

[alamb]

Yeah, I agree the tests are a little out of place here -- in general it seems like we have some tests in parser.rs that really belong in src/tests/...

I'll move them around in a follow on PR

[alamb]

#845

[coveralls]

Pull Request Test Coverage Report for Build 4534413969

• 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 86.299%

---

Totals
Change from base Build 4524349703:	0.01%
Covered Lines:	13926
Relevant Lines:	16137

---

💛 - Coveralls

[alamb]

Thanks @nicksrandall and @ankrgyl