Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Latin characters support #840

Merged
merged 2 commits into from Mar 23, 2023
Merged

Non-Latin characters support #840

merged 2 commits into from Mar 23, 2023

Conversation

mskrzypkows
Copy link
Contributor

No description provided.

mskrzypkows and others added 2 commits March 21, 2023 13:20
@mskrzypkows
Non latin characters
ce00851 
---------

Co-authored-by: Maciej Skrzypkowski <maciej.skrzypkowski@satoricyber.com>
Test for mysql
9f301bc
@coveralls
Copy link

coveralls commented Mar 21, 2023 •
edited

Pull Request Test Coverage Report for Build 4478961184

  • 19 of 19 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 86.117%
Totals Coverage Status
Change from base Build 4456045946: -0.008%
Covered Lines: 13566
Relevant Lines: 15753
💛 - Coveralls

ankrgyl
ankrgyl reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@ankrgyl ankrgyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems fine to me. @alamb is there any pre-existing context about the use of ASCII-only that could be relevant?

@alamb
Copy link
Collaborator

alamb commented Mar 21, 2023

This approach seems fine to me. @alamb is there any pre-existing context about the use of ASCII-only that could be relevant?

I do not have any such context. Maybe @andygrove @nickolay @Dandandan or @maxcountryman would like to weigh in

alamb
alamb approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @mskrzypkows and @ankrgyl for the review

@nickolay
Copy link
Collaborator

For the MSSQL dialect I just didn’t need it personally. Figured it was better to leave it unimplemented, rather than produce a possibly buggy solution or read up on Unicode character classes in Rust. Thanks for figuring it out!

@alamb alamb merged commit a1b7341 into sqlparser-rs:main Mar 23, 2023
9 checks passed
mobuchowski pushed a commit to OpenLineage/sqlparser-rs that referenced this pull request Aug 7, 2023
@mskrzypkows @mobuchowski
Non-Latin characters support (sqlparser-rs#840)
439fd61 
* Non latin characters

---------

Co-authored-by: Maciej Skrzypkowski <maciej.skrzypkowski@satoricyber.com>

* Test for mysql

---------

Co-authored-by: Maciej Skrzypkowski <maciej.skrzypkowski@satoricyber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankrgyl ankrgyl ankrgyl left review comments

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mskrzypkows @coveralls @alamb @nickolay @ankrgyl