feat: support BIGNUMERIC of bigquery
#811
Merged
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4311890584
💛 - Coveralls |
AugustoFKL
suggested changes
Feb 25, 2023
| @@ -3658,6 +3658,69 @@ fn parse_json_keyword() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_bignumeric_keyword() { | |||
There was a problem hiding this comment.
@togami2864, can you please add tests for the resulting string?
There was a problem hiding this comment.
Sorry, what do you mean by 'resulting string'?
There was a problem hiding this comment.
After parsing a statement with this clause, what's the re-serialization of the query? (usually we use the verified_stmt or one_parses_to functions)
src/ast/data_type.rs
Outdated
Comment on lines
82
to
91
|
|
||
| /// BigNumeric type used in BigQuery | ||
| /// | ||
| /// [bigquery]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | ||
| BigNumeric, | ||
|
|
||
| /// This is alias for BigNumeric type used in BigQuery | ||
| /// | ||
| /// [bigquery]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | ||
| BigDecimal, |
There was a problem hiding this comment.
- Why the spaces between the data types? Seems unnecessary
- The link you put is related to nothing.
What about:
Suggested change
| /// BigNumeric type used in BigQuery | |
| /// | |
| /// [bigquery]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | |
| BigNumeric, | |
| /// This is alias for BigNumeric type used in BigQuery | |
| /// | |
| /// [bigquery]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | |
| BigDecimal, | |
| /// [BigNumeric] type used in BigQuery | |
| /// | |
| /// [BigNumeric]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | |
| BigNumeric, | |
| /// This is alias for [BigNumeric] type used in BigQuery | |
| /// | |
| /// [BigNumeric]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | |
| BigDecimal, |
src/ast/data_type.rs
Outdated
Comment on lines
209
to
210
| DataType::BigNumeric => write!(f, "BIGNUMERIC"), | ||
| DataType::BigDecimal => write!(f, "BIGDECIMAL"), |
There was a problem hiding this comment.
You're not adding the precision/scale for those types. Any reason why?
Are you only focused on literals?
There was a problem hiding this comment.
I just considered for literals at first, but found that BigNumeric & Numeric with precision/scale are used in bq scripting. https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#parameterized_data_types
I'll implement because this is needed in the future.
alamb
reviewed
Mar 1, 2023
src/ast/data_type.rs
Outdated
| /// | ||
| /// [BigNumeric]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | ||
| BigNumeric(ExactNumberInfo), | ||
| /// This is alias for [BigNumeric] type used in BigQuery |
There was a problem hiding this comment.
Suggested change
| /// This is alias for [BigNumeric] type used in BigQuery | |
| /// This is alias for [BigDecimal] type used in BigQuery |
src/ast/data_type.rs
Outdated
| BigNumeric(ExactNumberInfo), | ||
| /// This is alias for [BigNumeric] type used in BigQuery | ||
| /// | ||
| /// [BigNumeric]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals |
There was a problem hiding this comment.
Suggested change
| /// [BigNumeric]: https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals | |
| /// [BigDecimal]: https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#decimal_types |
togami2864
force-pushed
the
feat/bq-numeric-keyword
branch
from
2e6bbdc to
ffd79da
Compare
togami2864
force-pushed
the
feat/bq-numeric-keyword
branch
from
ffd79da to
698cb41
Compare
alamb
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support
BIGNUMERIC&BIGDECIMALused in BIgQuery.https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#bignumeric_literals
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#decimal_types