Add User to README #787
Add User to README #787
Conversation
Pull Request Test Coverage Report for Build 3823971501
💛 - Coveralls |
| @@ -93,7 +93,7 @@ $ cargo run --features json_example --example cli FILENAME.sql [--dialectname] | |||
| ## Users | |||
|
|
|||
| This parser is currently being used by the [DataFusion] query engine, | |||
| [LocustDB], [Ballista] and [GlueSQL]. | |||
| [LocustDB], [Ballista], [GlueSQL], and [Opteryx]. | |||
There was a problem hiding this comment.
@AugustoFKL I don't think "Acknowledgements" is quite right as we are not really acknowledging assistance from other projects.
The point of this section, as I understand, is basically to encourage more use of the sqlparser crate by offering evidence that other projects have found it valuable enough to use.
Perhaps we could change the heading (in a different PR) to something like 'Powered By' to follow https://arrow.apache.org/powered_by/ ?
| @@ -93,7 +93,7 @@ $ cargo run --features json_example --example cli FILENAME.sql [--dialectname] | |||
| ## Users | |||
|
|
|||
| This parser is currently being used by the [DataFusion] query engine, | |||
| [LocustDB], [Ballista] and [GlueSQL]. | |||
| [LocustDB], [Ballista], [GlueSQL], and [Opteryx]. | |||
There was a problem hiding this comment.
@AugustoFKL I don't think "Acknowledgements" is quite right as we are not really acknowledging assistance from other projects.
The point of this section, as I understand, is basically to encourage more use of the sqlparser crate by offering evidence that other projects have found it valuable enough to use.
Perhaps we could change the heading (in a different PR) to something like 'Powered By' to follow https://arrow.apache.org/powered_by/ ?
Existing README welcomes PRs with additional users of this library - this PR adds a reference to Opteryx.
I also added a comma, I'm not sure if it was missing because of style or a typo but commas save lives so I added one.