supporting snowflake extract syntax #1374
Merged
+78
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seve-martinez
force-pushed
the
smartinez/supporting_snowflake_extract_syntax
branch
from
ebff9ba to
d4a78f2
Compare
iffyio
reviewed
Aug 11, 2024
|
@iffyio thank you for the review. I've updated the PR per your suggestions. Snowflake also offers the option to pass a string to the EXTRACT('hour', foo)I've updated this PR to include that use case as well. |
seve-martinez
force-pushed
the
smartinez/supporting_snowflake_extract_syntax
branch
from
d23d250 to
35b7656
Compare
iffyio
approved these changes
Aug 12, 2024
alamb
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Thank you @seve-martinez and @iffyio for the review. Looks great to me
…snowflake_extract_syntax
|
I took the liberty of running |
Pull Request Test Coverage Report for Build 10369115339Details
💛 - Coveralls |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1373