Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allocate in impl Display for DateTimeField #1209

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Do not allocate in impl Display for DateTimeField #1209

merged 1 commit into from
Apr 9, 2024

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Apr 9, 2024

Follow up to #1191 from @iffyio 馃檹

This avoids allocating in the Display impl of DateTimeField

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8622424693

Details

  • 40 of 42 (95.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.027%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/value.rs 40 42 95.24%
Totals Coverage Status
Change from base Build 8622401139: 0.02%
Covered Lines: 21225
Relevant Lines: 24112
馃挍 - Coveralls

@alamb alamb merged commit a0ed14c into sqlparser-rs:main Apr 9, 2024
10 checks passed
@alamb alamb mentioned this pull request Apr 10, 2024
Merged
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
@alamb @JichaoS
Do not allocate in impl Display for DateTimeField (sqlparser-rs#1209)
1858331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alamb @coveralls